This repository has been archived by the owner on Aug 18, 2024. It is now read-only.
D10 compatibility #754
Merged
D10 compatibility #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPParsley
approved these changes
Nov 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review notes
::accessCheck()to all entity queries (see https://www.drupal.org/node/3201242) without any argument, meaning the access is checked. I did this in order to preserve the current code behavior. However, I'm not sure that this is correct for all the cases. It's not in the scope of this PR to fix potential cases where the entity query should bypass the current user access constraint. The module maintainer should carefully review each case and fix potential cases in a followup.OgRole::calculateDependencies(). The module maintainer should weight on the@todoand, potentially, handle that in a followup.