Consistency fixes, and added error/residual methods to Coreg class. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 13, 2021
…ich is not always faster on GitHub's CI
adehecq
reviewed
May 18, 2021
| biascorr = coreg.BiasCorr() | ||
| icp = coreg.ICP() | ||
|
|
||
| pytest.raises(ValueError, biascorr.fit, dem1, dem2, transform=affine) |
There was a problem hiding this comment.
Does this function just check that the method biascorr.fit with arguments dem1, dem2 and tranform raises a ValueError??
adehecq
reviewed
May 18, 2021
|
|
||
| def error(self, reference_dem: Union[np.ndarray, np.ma.masked_array], | ||
| dem_to_be_aligned: Union[np.ndarray, np.ma.masked_array], | ||
| error_type: str = "nmad", |
There was a problem hiding this comment.
Looks really great! Just one comment is that sometimes one might want more than just one statistics, and it is counter-productive to calculate the residuals each time. So it would be nice to be able to request several statistics at once rather than only one...
adehecq
reviewed
May 18, 2021
| entries = mask.ds[mask.ds.intersects(shapely.geometry.box(*self.bounds))] | ||
|
|
||
| ddem_mask = nans.copy() | ||
| ddem_mask = nans.copy().squeeze() |
There was a problem hiding this comment.
I thought in this new implementation, the squeeze was not needed anymore?
|
Very nice fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are getting quite many issues, and many of them are relatively small. I therefore decided to just tackle a few in one PR!
Coregcentroid if it exists #114: ACoreg.centroid()method now exists which fetches the centroid if it exists.coreg.ICPmay raise confusing cv2.error instead of a builtin error #113: A more descriptiveValueErrorreplaces the cv2 error.coreg.BiasCorrwarns for all-nans but doesn't fail #112: AllCoregapproaches now raise an error if only nans are encountered.apply_matrix()function further. #110: The better "check if matrix is only vertical" suggestion by @adehecq is implemented.spatial_tools.get_array_and_mask()now converts to (height, width) and raises an error if it can't be converted..error()method or similar toCoregclass #76: ACoreg.residuals()method is added. Then aCoreg.error()method is added for preset error measures made form the residuals.spatial_tools.nmad()to work properly with masked_arrays. (previously, the mask was ignored)