Add a function for subsampling functionality #141
Conversation
|
So should we merge this? @adehecq |
xdem/spatial_tools.py
Outdated
| valids = np.argwhere(~mask.flatten()).squeeze() | ||
|
|
||
| # Checks that array and npoints are correct | ||
| assert np.ndim(valids) == 1 |
There was a problem hiding this comment.
This will raise an AssertionError without explanation. Could one be added? Python's AssertionErrors are inherently a little annoying I think because they don't tell the user anything!!
There was a problem hiding this comment.
Good point, but actually, I don't think this error should ever happen. It's just to make sure that the array has been flattened correctly and has the expected shape.
I can write "Something is wrong with array dimension, check input data and shape"
xdem/spatial_tools.py
Outdated
| """ | ||
| Randomly subsample a 1D or 2D array by a subsampling factor, taking only non NaN/masked values. | ||
|
|
||
| :param subsample: If < 1, will be considered a fraction of valid pixels to extract. |
There was a problem hiding this comment.
If <= 1 (to be consistent with the functionality)
|
Is this ready for approval? It looks great now in my book! |
+1 |
Yes, I just need to check that the tests pass and run the linters. |
Of course, I naturally write good code! ;-) |
As mentioned in PR #135, a shared subsampling function would be useful.
Done:
To do: