-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to python 3.10
in CI and remove python 3.7
#279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update upstream
…different type of numerical
adehecq
reviewed
Aug 9, 2022
adehecq
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change in the title.
Also ran into the issue of RuntimeWarning with NaNs of #260 again. I fixed it by using
np.full(shape, np.nan)
to initialize a NaN array instead of multiplying or addingnp.zeros()
,np.ones()
ornp.empty()
withnp.nan
like we have the (now bad?) habit of doing.The
dtype
ofnp.full
(previouslynp.empty
) is not set todem.dtype
anymore. This change was triggered by failing doctests with thisdtype
forcing because, if a DEM is an integer, terrain attributes derived from it would be forced to integers (and some attributes are between 0 and 1). The failure of tests only happened in this PR because thedtype
argument works differently if initiated innp.full
or if bynp.empy
later multiplied by NaN. Thenp.empty
multiplied by NaN actually ignored thedtype
all along.Added a point on this in the wiki (https://github.com/GlacioHack/xdem/wiki/Stuck-on-a-mysterious-error-during-CI%3F):
Resolves #249
Resolves #260