-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage from Coveralls in CI #281
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update upstream
adehecq
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition! Thanks for getting into this!
elischwat
added a commit
to elischwat/xdem
that referenced
this pull request
Dec 1, 2023
This reverts commit 63c3da4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During CI in GitHub Actions, we now compute the test coverage, upload it to Coveralls, and display the coverage badge on the README. Our current code is covered by tests at 80%, see details at https://coveralls.io/github/GlacioHack/xdem.
In steps:
pytest
to output the coverage with the--cov
option,coverage
file is then converted to LCOV format bycoveragepy-lcov
(needs python>3.8). The issue of creating a LCOV output will be solved soon inpytest
: Add support for LCOV output pytest-dev/pytest-cov#536, at which point with can simply pass--cov-report=lcov
topytest
,test
,finish
.