Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get consistent scipy.optimize outputs out of NuthKaab #322

Merged
merged 17 commits into from
Oct 25, 2022

Conversation

rhugonnet
Copy link
Member

@rhugonnet rhugonnet commented Oct 17, 2022

This PR fixes the outputs of NuthKaab for all operating systems. This is done by rounding the outputs of scipy.optimize.least_squares that have varying floating precision to 1e-2.
A test is added to test_coreg.py to specifically check the Coreg metadata out of the example, to know where changes are ocurring.

Opened #327. This issue mentions in particular that scipy.optimize functions should be called from fit.py, in order to have consistent tests on the tolerance and outputs of fitting methods, to continue addressing #310.

Partially addresses #310

@adehecq adehecq mentioned this pull request Oct 18, 2022
2 tasks
@rhugonnet rhugonnet changed the title Get consistent scipy.optimize outputs between OS Get consistent scipy.optimize outputs out of NuthKaab Oct 25, 2022
@rhugonnet
Copy link
Member Author

Will merge this now so that xDEM's build passes again after #257

@rhugonnet rhugonnet requested a review from adehecq October 25, 2022 10:27
Copy link
Member

@adehecq adehecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so basically all you did was to round the output of the parameter fit, and then update the expected output?

@rhugonnet
Copy link
Member Author

Yes !

@rhugonnet rhugonnet merged commit ecc7a9c into GlacioHack:main Oct 25, 2022
@rhugonnet rhugonnet deleted the fix_scipy_os branch October 25, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants