-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get consistent scipy.optimize
outputs out of NuthKaab
#322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
rhugonnet
changed the title
Get consistent
Get consistent Oct 25, 2022
scipy.optimize
outputs between OSscipy.optimize
outputs out of NuthKaab
Will merge this now so that xDEM's build passes again after #257 |
adehecq
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so basically all you did was to round the output of the parameter fit, and then update the expected output?
Yes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the outputs of
NuthKaab
for all operating systems. This is done by rounding the outputs ofscipy.optimize.least_squares
that have varying floating precision to 1e-2.A test is added to
test_coreg.py
to specifically check theCoreg
metadata out of the example, to know where changes are ocurring.Opened #327. This issue mentions in particular that
scipy.optimize
functions should be called fromfit.py
, in order to have consistent tests on the tolerance and outputs of fitting methods, to continue addressing #310.Partially addresses #310