Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing 'import numpy as np' statements to code examples #75

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Added missing 'import numpy as np' statements to code examples #75

merged 1 commit into from
Apr 13, 2021

Conversation

erikmannerfelt
Copy link
Contributor

Found by @adehecq

@erikmannerfelt erikmannerfelt added the documentation Improvements or additions to documentation label Apr 8, 2021
@erikmannerfelt erikmannerfelt requested a review from adehecq April 8, 2021 10:34
adehecq
adehecq reviewed Apr 8, 2021
View reviewed changes
Copy link
Member

@adehecq adehecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the associated python codes (the source of the figures) in the GitHub repo, or somewhere else?

@erikmannerfelt
Copy link
Contributor Author

They are in the documentation: docs/source/comparison.py and can be downloaded from https://xdem.readthedocs.io as I assumed you did.

@erikmannerfelt
Copy link
Contributor Author

Is this okay to merge?

@adehecq
Copy link
Member

adehecq commented Apr 13, 2021

Yes!

@erikmannerfelt erikmannerfelt merged commit 03fb47d into GlacioHack:main Apr 13, 2021
@erikmannerfelt erikmannerfelt mentioned this pull request Apr 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adehecq adehecq adehecq left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikmannerfelt @adehecq