-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zigbee2mqtt device parser #1302
Zigbee2mqtt device parser #1302
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1302 +/- ##
==========================================
- Coverage 96.64% 96.54% -0.11%
==========================================
Files 684 613 -71
Lines 8994 8729 -265
==========================================
- Hits 8692 8427 -265
Misses 302 302
Continue to review full report at Codecov.
|
034f76d
to
ac54d97
Compare
cea535d
to
e8e9a98
Compare
e8e9a98
to
fff9332
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fff9332
to
73ea5e2
Compare
f6abbb1
to
ce82979
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi !
Thanks for this PR, it looks super clean to me! :)
I added a few questions on gas sensors, but that's really a minor feedback just to be sure.
If you are confident it works fine, I'm ok to merge this 🙂 (I saw several people saying that it works fine on the forum, so it seems good to me)
Thanks, |
Ok, so I can merge this now ? |
Yes !!! :D |
Job #136: Bundle Size — 6.67MB (0%).Changed assets by type (0/7)
|
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.[ ] Did you add fake requests data for the demo mode (front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Add automatic device builder from Zigbee2mqtt device definition message.
Now service read the MQTT retained message from zigbee2mqtt containing device definition and map it to Gladys device / features : https://www.zigbee2mqtt.io/information/mqtt_topics_and_message_structure.html#zigbee2mqttbridgedevices
No more "device model" mapping.
Tests from : https://community.gladysassistant.com/t/zigbee2mqtt-debug/6080/46?u=alextrovato