-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature component #1352
Feature component #1352
Conversation
2457f79
to
94b014d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1352 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 613 613
Lines 8729 8729
=======================================
Hits 8427 8427
Misses 302 302 Continue to review full report at Codecov.
|
94b014d
to
6e8466a
Compare
It looks super clean! 😍 Thanks for those littles things, it's really nice :) |
038b121
to
49a3e9f
Compare
49a3e9f
to
1d1fe0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! It's way better with all code centralized in one place :)
Good job 👏
1d1fe0e
to
a24d528
Compare
Job #146: Bundle Size — 6.67MB (-0.12%).Changed metrics (4/8)
Changed assets by type (2/7)
|
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
[ ] If your changes affects code, did your write the tests?npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Introduce common "DeviceFeatures" and "BatteryLevelFeature" components.
Battery Level Component
Use same component for battery level display.
Add color according to battery level:
level < 10
10 <= level < 25
level >= 25
Device feature components