Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple chart fixes #1357

Merged
merged 5 commits into from
Nov 11, 2021
Merged

Multiple chart fixes #1357

merged 5 commits into from
Nov 11, 2021

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Nov 11, 2021

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Screenshot 2021-11-11 at 13 29 13

Screenshot 2021-11-11 at 14 16 59

@relativeci
Copy link

relativeci bot commented Nov 11, 2021

Job #145: Bundle Size — 6.67MB (+0.03%).

b3fa509 vs d389a14

Changed metrics (2/8)
Metric Current Baseline
Initial JS 2.87MB(+0.03%) 2.87MB
Cache Invalidation 59.37% 0%
Changed assets by type (2/7)
            Current     Baseline
CSS 329.79KB (+0.03%) 329.68KB
JS 4.77MB (+0.05%) 4.76MB

View Job #145 report on app.relative-ci.com

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #1357 (99938cc) into master (d389a14) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1357      +/-   ##
==========================================
- Coverage   96.60%   96.54%   -0.07%     
==========================================
  Files         613      613              
  Lines        8729     8729              
==========================================
- Hits         8433     8427       -6     
- Misses        296      302       +6     
Impacted Files Coverage Δ
server/models/dashboard.js 100.00% <ø> (ø)
server/utils/childProcess.js 66.66% <0.00%> (-33.34%) ⬇️
server/utils/functionsWrapper.js 71.42% <0.00%> (-28.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d389a14...99938cc. Read the comment docs.

Copy link
Contributor

@atrovato atrovato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great (on code review), just a simple comment on dupe check.

front/src/components/boxs/chart/Chart.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@atrovato atrovato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice enough to me :)

@Pierre-Gilles Pierre-Gilles merged commit b3fa509 into master Nov 11, 2021
@Pierre-Gilles Pierre-Gilles deleted the aggregate-fixes branch November 11, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants