-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple chart fixes #1357
Multiple chart fixes #1357
Conversation
Job #145: Bundle Size — 6.67MB (+0.03%).Changed metrics (2/8)
Changed assets by type (2/7)
|
Codecov Report
@@ Coverage Diff @@
## master #1357 +/- ##
==========================================
- Coverage 96.60% 96.54% -0.07%
==========================================
Files 613 613
Lines 8729 8729
==========================================
- Hits 8433 8427 -6
- Misses 296 302 +6
Continue to review full report at Codecov.
|
…ly the first + add units to legend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great (on code review), just a simple comment on dupe check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice enough to me :)
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change