-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding top/bottom button to navigate within pages #1944
Adding top/bottom button to navigate within pages #1944
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1944 +/- ##
==========================================
+ Coverage 98.17% 98.19% +0.01%
==========================================
Files 776 787 +11
Lines 12176 12293 +117
==========================================
+ Hits 11954 12071 +117
Misses 222 222 ☔ View full report in Codecov by Sentry. |
Job #2140: Bundle Size — 9.09MiB (+0.04%).
Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #2140 report View antoinech2:navigation-button-v2 branch activity |
…Gladys into navigation-button-v2
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server) No backend modification. Error for front tests but it's the same for master.npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
We are a group of 7 French students in engineering school and it is our first time contributing to an open source project like this one. Please do not hesitate to tell us if we've done anything wrong.
We added two navigation buttons within pages to directly go to top or bottom of the page.
Screenshots :
![drawing](https://private-user-images.githubusercontent.com/42295406/284869686-18b0ee55-ceee-41a8-8c0a-5896292eb9cc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzMyNDQsIm5iZiI6MTczOTMzMjk0NCwicGF0aCI6Ii80MjI5NTQwNi8yODQ4Njk2ODYtMThiMGVlNTUtY2VlZS00MWE4LThjMGEtNTg5NjI5MmViOWNjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA0MDIyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc5NTJmZjZlMDIyMTNhOTU0NTdkYjhjMjBmYjgyZTMyMTU1YjM5ZjdiYTAxMjBlYjdkNDYzYzQ0ZDExZmFlODAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.5j1cCFAU6IIvWSl7d-08slSuE6qlfKSTJk-oKloJusI)
![drawing](https://private-user-images.githubusercontent.com/42295406/284869527-b744eaf3-dfa0-4653-9e72-e334ed796b83.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzMyNDQsIm5iZiI6MTczOTMzMjk0NCwicGF0aCI6Ii80MjI5NTQwNi8yODQ4Njk1MjctYjc0NGVhZjMtZGZhMC00NjUzLTllNzItZTMzNGVkNzk2YjgzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA0MDIyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNjNzM1NjQ0MGRiZWFhYTZmYzY3ZGY5M2Y5NjA5NzJmZjhkYjBiM2UwZmVkYzNkNTQ3ZGYwMDZlYWZmOTY1ZDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.KdGd-aYrViw6dwGAiiMhu4G9uHZv_PQKBqV6FISPBkg)
![drawing](https://private-user-images.githubusercontent.com/42295406/284869586-0ede3a07-7183-4c7b-807e-bc38ba1233e1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzMyNDQsIm5iZiI6MTczOTMzMjk0NCwicGF0aCI6Ii80MjI5NTQwNi8yODQ4Njk1ODYtMGVkZTNhMDctNzE4My00YzdiLTgwN2UtYmMzOGJhMTIzM2UxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA0MDIyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNjYjIzOTgzZDllOWU5YWM2YTRhODM5ODE0ZWIwMTNkYmJkMTUwNjE4ZjFiNThhMTNjN2Y0Yzk3MWQ0NTVhMjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.PUIAkhFdakfFCNxUVx5Py6cT-9QuH8YT-3zNE5q-v0Y)
To do for a V2 :