Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding top/bottom button to navigate within pages #1944

Closed

Conversation

antoinech2
Copy link

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests? No backend modification
  • Are tests passing? (npm test on both front/server) No backend modification. Error for front tests but it's the same for master.
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging. We tested on the Gladys interface
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

We are a group of 7 French students in engineering school and it is our first time contributing to an open source project like this one. Please do not hesitate to tell us if we've done anything wrong.

We added two navigation buttons within pages to directly go to top or bottom of the page.

Screenshots :
drawing
drawing
drawing

To do for a V2 :

  • Remove button on certain pages where it is not useful
  • Update button state when changing page / test that everything works fine in fullscreen.

@antoinech2 antoinech2 changed the title Adding top/bottom button to navigate through pages Adding top/bottom button to navigate within pages Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfbb25b) 98.17% compared to head (318bcdb) 98.19%.
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1944      +/-   ##
==========================================
+ Coverage   98.17%   98.19%   +0.01%     
==========================================
  Files         776      787      +11     
  Lines       12176    12293     +117     
==========================================
+ Hits        11954    12071     +117     
  Misses        222      222              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Nov 22, 2023

Job #2140: Bundle Size — 9.09MiB (+0.04%).

318bcdb(current) vs bfbf817 master#2133(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 2 regressions
                 Current
Job #2140
     Baseline
Job #2133
Regression  Initial JS 4.91MiB(+0.07%) 4.9MiB
Regression  Initial CSS 302.83KiB(+0.12%) 302.47KiB
Change  Cache Invalidation 57.09% 70.96%
No change  Chunks 51 51
No change  Assets 158 158
Change  Modules 1423(+0.14%) 1421
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
Job #2140
     Baseline
Job #2133
Regression  JS 6.58MiB (+0.05%) 6.57MiB
Not changed  IMG 2.08MiB 2.08MiB
Regression  CSS 319.33KiB (+0.11%) 318.98KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 16.14KiB 16.14KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2140 reportView antoinech2:navigation-button-v2 branch activity

Copy link

stale bot commented Feb 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 4, 2024
@stale stale bot closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants