Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add doc link on each integration + style consistency #1969

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

jbrisavoine
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Following the request https://community.gladysassistant.com/t/rendre-les-menus-homogene/8581/1:

  • Add documentation link on each integration pages.
  • Change icons and style for consistency
  • Update src/components/documentation/DeviceConfigurationLink.jsx to be able to chose the path of the documentation

Before:
2023 12 07_PR_BEFORE

After:
2023 12 07_PR_AFTER

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d740f0) 0.00% compared to head (be80e9a) 98.19%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1969       +/-   ##
===========================================
+ Coverage        0   98.19%   +98.19%     
===========================================
  Files           0      787      +787     
  Lines           0    12293    +12293     
===========================================
+ Hits            0    12071    +12071     
- Misses          0      222      +222     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Dec 7, 2023

Job #2153: Bundle Size — 9.11MiB (+0.21%).

be80e9a(current) vs 621c0c5 master#2150(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
Job #2153
     Baseline
Job #2150
Regression  Initial JS 4.93MiB(+0.39%) 4.91MiB
No change  Initial CSS 302.47KiB 302.47KiB
No change  Cache Invalidation 53.85% 53.85%
No change  Chunks 51 51
No change  Assets 158 158
No change  Modules 1421 1421
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #2153
     Baseline
Job #2150
Regression  JS 6.59MiB (+0.29%) 6.57MiB
Not changed  IMG 2.08MiB 2.08MiB
Not changed  CSS 318.98KiB 318.98KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 16.14KiB 16.14KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2153 reportView jbrisavoine:front-menu-homogene branch activity

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR ! I have a few feedbacks on the included files in this PR, but nothing really serious :)

For the Camera integration, it seems a bit too compact since the change, could we increase the width of each camera box ?

Screenshot 2023-12-08 at 09 57 25

Maybe we can put 2 cameras per row now?

@jbrisavoine
Copy link
Contributor Author

Fix size of camera box
2023 12 08_PR_FIX

@jbrisavoine jbrisavoine closed this Dec 8, 2023
@jbrisavoine jbrisavoine reopened this Dec 8, 2023
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! :)

@Pierre-Gilles Pierre-Gilles merged commit 915567d into GladysAssistant:master Dec 15, 2023
@Pierre-Gilles
Copy link
Contributor

@all-contributors please add jbrisavoine for code

Copy link
Contributor

@Pierre-Gilles

I've put up a pull request to add @jbrisavoine! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants