Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boxs): Add Motion Sensor Device #2028

Merged

Conversation

cicoub13
Copy link
Contributor

@cicoub13 cicoub13 commented Feb 17, 2024

This PR is adding a Motion Sensor Device row to display "Motion detected" when the device is sending a 1 value and the last time seen when it's not

Detection No detection

image

image

You can follow discussion here in the community https://community.gladysassistant.com/t/dashboard-etat-detecteur-de-mouvement/8508/14?u=cicoub13

This could be extended later to Presence Sensor (with a different text like "Presence detected")

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.32%. Comparing base (185fe8a) to head (a186c34).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2028   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files         836      836           
  Lines       13269    13269           
=======================================
  Hits        13047    13047           
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Feb 17, 2024

Job #2393: Bundle Size — 9.83MiB (+0.01%).

a186c34(current) vs 185fe8a master#2390(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
Job #2393
     Baseline
Job #2390
Regression  Initial JS 5.34MiB(~+0.01%) 5.34MiB
No change  Initial CSS 303.16KiB 303.16KiB
Change  Cache Invalidation 63% 0%
No change  Chunks 51 51
No change  Assets 165 165
Change  Modules 1455(+0.07%) 1454
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.8% 0.8%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #2393
     Baseline
Job #2390
Regression  JS 7.03MiB (+0.01%) 7.03MiB
Not changed  IMG 2.37MiB 2.37MiB
Not changed  CSS 319.67KiB 319.67KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 16.93KiB 16.93KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2393 reportView cicoub13:feat-motion-detection-b... branch activityView project dashboard

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, works fine on my side !

@Pierre-Gilles Pierre-Gilles merged commit ab7ffa9 into GladysAssistant:master Feb 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants