-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new integration Free Mobile SMS #2157
base: master
Are you sure you want to change the base?
add new integration Free Mobile SMS #2157
Conversation
#2890 Bundle Size — 10.4MiB (+0.65%).33aabde(current) vs 8fff0ca master#2883(baseline) Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
Current #2890 |
Baseline #2883 |
|
---|---|---|
Initial JS | 5.64MiB (+0.31% ) |
5.62MiB |
Initial CSS | 304.89KiB |
304.89KiB |
Cache Invalidation | 54.95% |
57.81% |
Chunks | 51 |
51 |
Assets | 173 (+0.58% ) |
172 |
Modules | 1511 (+0.27% ) |
1507 |
Duplicate Modules | 21 |
21 |
Duplicate Code | 0.83% (-1.19% ) |
0.84% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
Bundle size by type 3 changes
3 regressions
Current #2890 |
Baseline #2883 |
|
---|---|---|
JS | 7.43MiB (+0.24% ) |
7.41MiB |
IMG | 2.54MiB (+1.99% ) |
2.49MiB |
CSS | 321.68KiB |
321.68KiB |
Fonts | 93.55KiB |
93.55KiB |
Other | 17.79KiB (+0.51% ) |
17.7KiB |
HTML | 13.58KiB |
13.58KiB |
Bundle analysis report Branch William-De71:new-integration-fre... Project dashboard
Generated by RelativeCI Documentation Report issue
60f9e27
to
2065f9f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2157 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 875 876 +1
Lines 14386 14410 +24
=======================================
+ Hits 14175 14199 +24
Misses 211 211 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small feedback, otherwise it looks good to me!
Can you write a documentation so the link is working?
<Text id="editScene.actionsCard.smsSend.explanationText" /> | ||
</div> | ||
<div className="tags-input"> | ||
<TextWithVariablesInjected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Add new integration to send SMS via the Free Mobile API