Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new integration Free Mobile SMS #2157

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

William-De71
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add new integration to send SMS via the Free Mobile API

Copy link

relativeci bot commented Nov 4, 2024

#2890 Bundle Size — 10.4MiB (+0.65%).

33aabde(current) vs 8fff0ca master#2883(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Regression 1 regression
                 Current
#2890
     Baseline
#2883
Regression  Initial JS 5.64MiB(+0.31%) 5.62MiB
No change  Initial CSS 304.89KiB 304.89KiB
Change  Cache Invalidation 54.95% 57.81%
No change  Chunks 51 51
Change  Assets 173(+0.58%) 172
Change  Modules 1511(+0.27%) 1507
No change  Duplicate Modules 21 21
Change  Duplicate Code 0.83%(-1.19%) 0.84%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
#2890
     Baseline
#2883
Regression  JS 7.43MiB (+0.24%) 7.41MiB
Regression  IMG 2.54MiB (+1.99%) 2.49MiB
No change  CSS 321.68KiB 321.68KiB
No change  Fonts 93.55KiB 93.55KiB
Regression  Other 17.79KiB (+0.51%) 17.7KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch William-De71:new-integration-fre...Project dashboard


Generated by RelativeCIDocumentationReport issue

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (8fff0ca) to head (33aabde).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2157   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         875      876    +1     
  Lines       14386    14410   +24     
=======================================
+ Hits        14175    14199   +24     
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small feedback, otherwise it looks good to me!
Can you write a documentation so the link is working?

<Text id="editScene.actionsCard.smsSend.explanationText" />
</div>
<div className="tags-input">
<TextWithVariablesInjected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a placeholder, it looks a bit empty:

Screenshot 2024-11-22 at 09 59 00

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be less empty now.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants