Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scenes): Add does not contain for Calendar action #2187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cicoub13
Copy link
Contributor

@cicoub13 cicoub13 commented Dec 17, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Provides a "does not contain" in "continue only if calendar event" action

image

⚠️ If multiple events are happening now and at least one contains the word, scene will stop.

@cicoub13 cicoub13 force-pushed the feat-calendar-does-not-contain branch from 531a32c to 0645580 Compare December 17, 2024 09:54
Copy link

relativeci bot commented Dec 17, 2024

#2990 Bundle Size — 10.42MiB (~+0.01%).

7b21800(current) vs c56d552 master#2983(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2990
     Baseline
#2983
Regression  Initial JS 5.65MiB(~+0.01%) 5.65MiB
No change  Initial CSS 304.87KiB 304.87KiB
Change  Cache Invalidation 54.1% 56.96%
No change  Chunks 51 51
No change  Assets 173 173
No change  Modules 1512 1512
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 6 changes Regression 6 regressions
                 Current
#2990
     Baseline
#2983
Regression  JS 7.44MiB (+100%) undefined
Regression  IMG 2.54MiB (+100%) undefined
Regression  CSS 321.77KiB (+100%) undefined
Regression  Fonts 93.55KiB (+100%) undefined
Regression  Other 17.79KiB (+100%) undefined
Regression  HTML 13.58KiB (+100%) undefined

Bundle analysis reportBranch cicoub13:feat-calendar-does-not-...Project dashboard


Generated by RelativeCIDocumentationReport issue

@cicoub13 cicoub13 force-pushed the feat-calendar-does-not-contain branch from 0645580 to c02c884 Compare January 27, 2025 14:35
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (c56d552) to head (7b21800).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2187   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         876      876           
  Lines       14455    14463    +8     
=======================================
+ Hits        14244    14252    +8     
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cicoub13 cicoub13 force-pushed the feat-calendar-does-not-contain branch from c02c884 to 87b2832 Compare January 27, 2025 16:37
@cicoub13 cicoub13 force-pushed the feat-calendar-does-not-contain branch from 87b2832 to 38ad832 Compare January 28, 2025 09:54
@cicoub13 cicoub13 force-pushed the feat-calendar-does-not-contain branch from 38ad832 to a243f19 Compare January 29, 2025 13:18
@cicoub13 cicoub13 force-pushed the feat-calendar-does-not-contain branch from a243f19 to 7b21800 Compare January 29, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants