Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import OpenZwave DB from Github #617

Closed

Conversation

sescandell
Copy link
Contributor

Description of change

Following the 2 comments in #614 here is a first PR about upgrading the OpenZwave DB but staying on the 1.4 OpenZwave version.
I don't think it would impact anything in code... just newer and recent devices will now be recognized.

Another PR is coming (tomorrow or after) to move on OpenZWave 1.6 (or not...);

I don't know where your script to generate the RPI Image reside. Let me know so I can update it too.

Thanks!

@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #617 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #617   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files         400      400           
  Lines        4876     4876           
=======================================
  Hits         4478     4478           
  Misses        398      398
Flag Coverage Δ
#server 91.83% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c8732...83e8e1b. Read the comment docs.

@Pierre-Gilles
Copy link
Contributor

Thanks for this PR! Did you test it?

This is a little hacky (imagine if the XML format changes between 2 versions, it'll break our image) so I would prefer switching directly to 1.6 if it works! Waiting for your other PR so :)

@sescandell
Copy link
Contributor Author

Thanks for this PR! Did you test it?

Yes... Well, basically but yes. I run the Docker with a custom volume doing the same thing as in this PR. I can validate that now, one of my device is well recognized (I can provide you screenshot if you want).

(imagine if the XML format changes between 2 versions, it'll break our image)

You totally right! I didn't thought about that. We can force a given commit (or a tag or...) to avoid that issue and be in control about the changes.

I'll do PR about the 1.6 update.

Thanks for your time!

@sescandell
Copy link
Contributor Author

sescandell commented Nov 27, 2019

Waiting for the other PR, I'm closing that one with a "local solution" for users whom would want to use the latest OpenZwave DB without affecting everybody.

Simply make the same manipulation on your machine and use the cloned repo as a mounted volume. In terms of commands:

# Clone the repo
git clone https://github.com/OpenZWave/open-zwave.git openzwave

# Run the Docker image with an additional volume (latest -v option here):
docker run -d \
    --restart=always \
    --privileged \
    --network=host \
    --name gladys \
    -e NODE_ENV=production \
    -e SERVER_PORT=80 \
    -e TZ=Europe/Paris \
    -e SQLITE_FILE_PATH=/var/lib/gladysassistant/001/gladys-production.db \
    -v /var/run/docker.sock:/var/run/docker.sock \
    -v /var/lib/gladysassistant/001:/var/lib/gladysassistant/001 \
    -v /dev:/dev \
    -v `pwd`/openzwave/config/:/etc/openzwave/ \
    gladysassistant/gladys:4.0.0-beta-arm

That way you can easily test it.

As soon as I have time (next week) I'll propose a PR for an full update to the 1.6

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants