Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Tasks.todoist #960

Closed

Conversation

GuillaumeNury
Copy link

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add a new box for Todoist tasks.

image
image
image

@GuillaumeNury
Copy link
Author

Bonsoir, je voulais intégrer Todoist sur mon dashboard. Voici mon intégration si ça vous intéresse.
(Si vous êtes intéressé, j'ajouterais les différents tests 😄)

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #960 (455680f) into master (765461e) will decrease coverage by 0.76%.
The diff coverage is 23.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #960      +/-   ##
==========================================
- Coverage   94.22%   93.46%   -0.77%     
==========================================
  Files         462      465       +3     
  Lines        6133     6200      +67     
==========================================
+ Hits         5779     5795      +16     
- Misses        354      405      +51     
Impacted Files Coverage Δ
server/models/dashboard.js 100.00% <ø> (ø)
server/utils/constants.js 100.00% <ø> (ø)
server/services/todoist/lib/index.js 8.33% <8.33%> (ø)
server/services/todoist/api/todoist.controller.js 21.42% <21.42%> (ø)
server/services/todoist/index.js 27.50% <27.50%> (ø)
server/services/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 765461e...455680f. Read the comment docs.

@cicoub13
Copy link
Contributor

cicoub13 commented Dec 1, 2020

It's working, easy to put in place and efficient 💪 Thanks. Some feedbacks about my first tests :

  • If you put a bad api Key, you have no error during setup. Can you do a "ping" just after saving the key ?
  • It could be awesome to let user add Task from box (or not if you think the idea is just remind tasks)
  • I often put due dates in my tasks and I think it could be easily added in the box

Capture d’écran 2020-12-01 à 23 04 40

@callemand callemand mentioned this pull request Feb 11, 2021
8 tasks
@VonOx
Copy link
Contributor

VonOx commented Mar 14, 2021

Close this one in favor of #1073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants