You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm currently running through adding some table funcs, and I'm unsure what gets run where.
The full interface:
#[async_trait]pubtraitTableFunc:Sync + Send{/// The name for this table function. This name will be used when looking up/// function implementations.fnname(&self) -> &str;fnruntime_preference(&self) -> RuntimePreference;fndetect_runtime(&self,_args:&[FuncParamValue],_parent:RuntimePreference,) -> Result<RuntimePreference>{Ok(self.runtime_preference())}/// Return a table provider using the provided args.asyncfncreate_provider(&self,ctx:&dynTableFuncContextProvider,args:Vec<FuncParamValue>,opts:HashMap<String,FuncParamValue>,) -> Result<Arc<dynTableProvider>>;/// Return the signature for this function./// Defaults to None.// TODO: Remove the default impl once we have `signature` implemented for all functionsfnsignature(&self) -> Option<Signature>{None}}
From what I'm reading, create_provideralways gets run remotely if runtime preference is remote. If this is the case, then that should be documented.
The text was updated successfully, but these errors were encountered:
We should only have 1 source of truth for runtime preference for the
functions. Here, `runtime_preference` method is removed so the runtime
is always calculated from `detect_runtime`.
Fixes#2165
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
We should only have 1 source of truth for runtime preference for the
functions. Here, `runtime_preference` method is removed so the runtime
is always calculated from `detect_runtime`.
Fixes#2165
---------
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
Description
I'm currently running through adding some table funcs, and I'm unsure what gets run where.
The full interface:
From what I'm reading,
create_provider
always gets run remotely if runtime preference is remote. If this is the case, then that should be documented.The text was updated successfully, but these errors were encountered: