You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Function names and function entries in the catalog are disjointed right now. When building the builtin catalog, all functions are iterated over, and placed into the default schema (public).
This is particularly troublesome with array_to_string since it's both a datafusion function, and an alias for postgres compatability (pg_catalog.array_to_string). However, the existing logic dumps pg_catalog.array_to_string into the default schema with the name array_to_string, completely disregarding the function namespace.
The function namespace should be used when determining which schema to place functions in. I think the easiest thing to do would be move namespace from BuiltinScalarUDF to BuiltinFunction, then get the namespace when building the catalog to get the appropriate schema.
The text was updated successfully, but these errors were encountered:
Closes#2368
Futzing around with function aliases. This replaces `HashMap` with
`AliasMap` to allow multiple keys to point to the same object. Also adds
some tests.
I needed to add a workaround for 'array_to_string' for one of the
iterators, see #2371.
Description
Followup from #2368
Function names and function entries in the catalog are disjointed right now. When building the builtin catalog, all functions are iterated over, and placed into the default schema (public).
This is particularly troublesome with
array_to_string
since it's both a datafusion function, and an alias for postgres compatability (pg_catalog.array_to_string
). However, the existing logic dumpspg_catalog.array_to_string
into the default schema with the namearray_to_string
, completely disregarding the function namespace.The function namespace should be used when determining which schema to place functions in. I think the easiest thing to do would be move
namespace
fromBuiltinScalarUDF
toBuiltinFunction
, then get the namespace when building the catalog to get the appropriate schema.The text was updated successfully, but these errors were encountered: