Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CREATE EXTERNAL TABLE support for excel #2644

Closed
Tracked by #1994
tychoish opened this issue Feb 14, 2024 · 3 comments · Fixed by #2684
Closed
Tracked by #1994

CREATE EXTERNAL TABLE support for excel #2644

tychoish opened this issue Feb 14, 2024 · 3 comments · Fixed by #2684
Labels
feat New feature or request

Comments

@tychoish
Copy link
Contributor

tychoish commented Feb 14, 2024 •
edited
Loading

Currently Excel file reading is only available as a table function, but we could support CREATE EXTERNAL TABLE from excel files as we do for other formats.

The code to do this is similar to the code for the other formats and there's nothing that is special about excel files, it's just a matter of hooking it all up and writing a few tests.
@tychoish tychoish mentioned this issue Feb 14, 2024
Closed
4 tasks
@tychoish tychoish added feat New feature or request good first issue 🆕 labels Feb 14, 2024
@greyscaled
Copy link
Contributor

greyscaled commented Feb 14, 2024 •
edited
Loading

Do I have it correct that we would start with create external table which would specify a sheet, and that we could later add create external database that maps all sheets to tables?

@hemanth94
Copy link
Contributor

@tychoish Can i try contributing to this?
Will ask for suggestions if needed.

Thanks,

@tychoish
Copy link
Contributor Author

@hemanth94 this would be great for you! I cannot imagine that there'll be anything unusual. the bson example, which I did recently, is pretty clean and might be a good thing to look at for a model.

@hemanth94 hemanth94 mentioned this issue Feb 15, 2024
Merged
@hailelagi hailelagi mentioned this issue Feb 22, 2024
Merged
universalmind303 added a commit that referenced this issue Feb 29, 2024
@hailelagi @tychoish @universalmind303
feat: support for create external table excel <options> (#2684)
0314c09 
closes #2644, summary of
changes:
- implements the `create external table excel <options>` sql command by
adding a "streaming table" interface that maps excel rows/columns into a
`RecordBatch`.

this will likely be superseded with a followup after the `TableProvider`
is implemented for (#2645) to
allow querying on tables and it's missing support for streaming multiple
sheets from a worksheet, it's also not super optimal quite yet, but
happy to iterate on it on this pr or a followup.

---------

Signed-off-by: Haile Lagi <52631736+hailelagi@users.noreply.github.com>
Co-authored-by: Sam Kleinman <sam@glaredb.com>
Co-authored-by: universalmind303 <cory.grinstead@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support for create external table excel <options>
3 participants
@tychoish @greyscaled @hemanth94