-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flightsql initial support #2219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing seems out of place.
@vrongmeal (et al) should take a look to make sure that the consumption metrics stuff is properly wired up (but that need not happen during this pr.
Metrics are not being collected here. Looking more into the PR on how this might be easier to plug-in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from metrics collection, this looks good to me! 🚀
@vrongmeal, I added a followup issue for setting up metrics |
example usage
See the official adbc flightsql docs for more info