Better formatting for FixedSizeList (#2058) #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hemanth94
changed the title
hemanth94
changed the title
|
thanks for the contribution @hemanth94. Looks like you still need to sign the CLA, and a few formatting issues that should get resolved once you run |
Co-authored-by: universalmind303 <universalmind.candy@gmail.com>
|
@hemanth94 It looks like you accidentally reverted the suggestion when you applied the formatting. Other than that, looks good to merge. |
|
@universalmind303 Thanks for the correction. |
|
@hemanth94 could you try signing the CLA thing again to get this unstuck? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2058
Trying to fix formatting for FixedSizeList.
I'm new to Open source contributions and I'm Learning rust for past couple of months.
Want to begin with good first issues and wish to contribute more to GlareDB.
Please correct me if needed.
Thanks.