fix: Properly exit SimpleExecuteQueryStream on stream end #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #2242 Also moves the simple stuff to its own module to split up the code a little bit.
scsmithr
commented
Dec 10, 2023
|
|
||
| // Stream completed without error, return success to the client. | ||
| Poll::Ready(None) => { | ||
| self.done = true; // Make sure we properly signal stream end on next poll. |
There was a problem hiding this comment.
This is the fix. Adds a bool so that next poll of this stream (no the inner stream) we exit.
universalmind303
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2242
Also moves the simple stuff to its own module to split up the code a little bit.