chore: Detect client disconnect in pg proxy #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Lowers log level for unexpected eof errors (client disconnects). - Raises log level for all other errors
greyscaled
approved these changes
Dec 14, 2023
|
can we mark this as closing the issue #2255 ? |
done |
tychoish
reviewed
Dec 14, 2023
crates/glaredb/src/pg_proxy.rs
Outdated
| @@ -85,7 +87,9 @@ impl PgProxy { | |||
| debug!("client connected (proxy)"); | |||
| match handler.proxy_connection(inbound).await { | |||
| Ok(_) => debug!("client disconnected"), | |||
| Err(e) => debug!(%e, "client disconnected with error."), | |||
| Err(PgSrvError::Io(e)) if e.kind() == io::ErrorKind::UnexpectedEof => | |||
| trace!("client disconnected"), | |||
There was a problem hiding this comment.
should the Ok() case also be a trace then? should we distinguish between the two?
There was a problem hiding this comment.
Downgraded debugs to trace, and used different messages in both cases (in case we need to distinguish).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2255