Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter unknown oids for Postgres types #2283

Merged
merged 3 commits into from
Dec 20, 2023
Merged

fix: filter unknown oids for Postgres types #2283

merged 3 commits into from
Dec 20, 2023

Conversation

hemanth94
Copy link
Contributor

Fixes issue : #2025
Filters out unknown type - oids and returns them in error log.
@scsmithr Please correct me if needed.

Thanks.

@tychoish tychoish changed the title Filtering unknown oids for Postgres types fix: filter unknown oids for Postgres types Dec 20, 2023
tychoish
tychoish approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@tychoish tychoish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scsmithr could you gut check this real quick too?

scsmithr
scsmithr approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@scsmithr scsmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Doesn't completely close the issue since we want to be able to handle the OIDs somehow (specifically enums), but this does provide a better error message.

@scsmithr scsmithr merged commit cdd010d into GlareDB:main Dec 20, 2023
12 checks passed
tychoish pushed a commit that referenced this pull request Dec 22, 2023
@hemanth94 @tychoish
fix: filter unknown oids for Postgres types (#2283)
8638a1d 
Fixes issue : #2025 
Filters out unknown type - oids and returns them in error log.
@scsmithr  Please correct me if needed.

Thanks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scsmithr scsmithr scsmithr approved these changes

@tychoish tychoish tychoish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hemanth94 @tychoish @scsmithr