Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hacky fix for running the experimental scheduler when spawning task #2284

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

vrongmeal
Copy link
Contributor

@vrongmeal vrongmeal commented Dec 20, 2023

Until I figure out the best solution (which hopefully is close).

Pushing just to benchmark and test stuff successfully.

To run the tokio console debugger:

  1. Download the CLI:
    cargo --locked tokio-console
    
  2. Build/Run local with new just commands (along with --debug-tokio flag):
    just run-debug-tokio local --debug-tokio
    

NOTE: This builds in a new target directory: unstable-tokio-target so as to not mess up with existing target directory (which can cause issues with LSP etc.).

Copy link
Contributor

@tychoish tychoish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to require/switch to the new scheduler via the command line.

also we should add a task to add a new matrix dimension to the SLT tests that would run with the new scheduler. (x pg x flight once this land and after this lands.)

crates/glaredb/src/commands.rs Show resolved Hide resolved
crates/sqlexec/src/distexec/scheduler.rs Show resolved Hide resolved
justfile Show resolved Hide resolved
@vrongmeal
Copy link
Contributor Author

is it possible to require/switch to the new scheduler via the command line.

No, unfortunately have to set it for the session.

@vrongmeal vrongmeal force-pushed the vrongmeal/executor-stuff branch from 710848d to 5e16060 Compare December 21, 2023 15:09
@vrongmeal vrongmeal enabled auto-merge (squash) December 26, 2023 09:48
@vrongmeal vrongmeal merged commit e8cec4f into main Dec 26, 2023
13 checks passed
@vrongmeal vrongmeal deleted the vrongmeal/executor-stuff branch December 26, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants