-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add non-cryptographic hash function #2298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
universalmind303
suggested changes
Dec 23, 2023
scsmithr
approved these changes
Dec 27, 2023
…o tycho/hashing-fnv-and-siphash
universalmind303
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2220
Notes:
While Rust's hashmaps use a siphash variant, they use a less less
common and less robust variant (for speed) reasons [which makes
sense for default hashmaps but less sense in other cases]. They also
deprecated the access to the specific algorithims, in a way that
makes me less confident that the undeprecated form will be
semantically stable.
I contemplated (and tried) to share the implementation, but: I think
these ought to be different functions and becuause the hashers are
stateful, I think we'd end up writing a lot more code with limited
benefit, but perhaps I've missed something.