Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add non-cryptographic hash function #2298

Merged
merged 23 commits into from
Dec 28, 2023
Merged

Conversation

tychoish
Copy link
Contributor

Part of #2220

Notes:

  • While Rust's hashmaps use a siphash variant, they use a less less
    common and less robust variant (for speed) reasons [which makes
    sense for default hashmaps but less sense in other cases]. They also
    deprecated the access to the specific algorithims, in a way that
    makes me less confident that the undeprecated form will be
    semantically stable.

  • I contemplated (and tried) to share the implementation, but: I think
    these ought to be different functions and becuause the hashers are
    stateful, I think we'd end up writing a lot more code with limited
    benefit, but perhaps I've missed something.

@tychoish tychoish changed the base branch from main to tycho/scalar-value-handling December 24, 2023 23:15
Base automatically changed from tycho/scalar-value-handling to main December 28, 2023 17:36
@tychoish tychoish enabled auto-merge (squash) December 28, 2023 18:17
@tychoish tychoish merged commit 026bacd into main Dec 28, 2023
13 checks passed
@tychoish tychoish deleted the tycho/hashing-fnv-and-siphash branch December 28, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants