Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Azure data dir #2319

Merged
merged 2 commits into from
Dec 29, 2023
Merged

feat: Add support for Azure data dir #2319

merged 2 commits into from
Dec 29, 2023

Conversation

vrongmeal
Copy link
Contributor 

$ AZURE_STORAGE_ACCOUNT_NAME=... \
  AZURE_STORAGE_ACCOUNT_KEY=... \
  glaredb --location "azure://vaibhav-test/path/to/db"

GlareDB (v0.7.1)
Persisting database at location: azure://vaibhav-test/path/to/db
Type \help for help.
>

$ glaredb --location "azure://vaibhav-test/path/to/db" \
  --option "account_name=..." \
  --option "access_key=..."

GlareDB (v0.7.1)
Persisting database at location: azure://vaibhav-test/path/to/db
Type \help for help.
>

@vrongmeal
feat: Add support for Azure data dir
2f33169 
```
$ AZURE_STORAGE_ACCOUNT_NAME=... \
  AZURE_STORAGE_ACCOUNT_KEY=... \
  glaredb --location "azure://vaibhav-test"

GlareDB (v0.7.1)
Persisting database at location: azure://vaibhav-test
Type \help for help.
>
```

```
$ glaredb --location "azure://vaibhav-test" \
  --option "account_name=..." \
  --option "access_key=..."

GlareDB (v0.7.1)
Persisting database at location: azure://vaibhav-test
Type \help for help.
>
```

Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal vrongmeal mentioned this pull request Dec 29, 2023
Open
3 tasks
@vrongmeal vrongmeal enabled auto-merge (squash) December 29, 2023 12:52
@vrongmeal vrongmeal merged commit 5000615 into main Dec 29, 2023
13 checks passed
@vrongmeal vrongmeal deleted the vrongmeal/azure-data-dir branch December 29, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scsmithr scsmithr scsmithr approved these changes

@universalmind303 universalmind303 Awaiting requested review from universalmind303

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrongmeal @scsmithr