chore: Allow specifying aliases for table functions #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of duplicating the function definition itself. Also a few cleanups.
| @@ -19,6 +19,7 @@ use table::{BuiltinTableFuncs, TableFunc}; | |||
|
|
|||
| /// Builtin table returning functions available for all sessions. | |||
| static BUILTIN_TABLE_FUNCS: Lazy<BuiltinTableFuncs> = Lazy::new(BuiltinTableFuncs::new); | |||
| // TODO: Why is this separate? | |||
There was a problem hiding this comment.
The arrow cast function has special handling in datafusion due to the dynamic return type. So it isn't a 'scalar_udf' and needs to be handled a bit differently.
There was a problem hiding this comment.
This constant wasn't used, so removed it. Also added a comment when generating the hashmap about the arrow_cast special case.
scsmithr
added a commit
that referenced
this pull request
Jan 7, 2024
```
> select * from read_csv('./testdata/csv/delimiter.csv', delimiter => ';');
┌───────┬──────────────┬─────────┐
│ col1 │ col2 │ col3 │
│ ── │ ── │ ── │
│ Int64 │ Utf8 │ Float64 │
╞═══════╪══════════════╪═════════╡
│ 1 │ hello, world │ 3.90000 │
│ 2 │ HELLO, WORLD │ 4.90000 │
└───────┴──────────────┴─────────┘
```
Depends on #2364
Adds the plumbing for getting options from the user in our various scan
functions. The only one wired up right now is 'delimiter' for csv, but
other options should be very straightforward to add in now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of duplicating the function definition itself.
Also a few cleanups.
Existing SLTs assert that this works as expected. SLTs for
parquet_scan, etc are just copies of theread_parquetones.