Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Error instead of panic when converting pg timestamps to arrow #2430

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: Error instead of panic when converting pg timestamps to arrow #2430

merged 1 commit into from
Jan 16, 2024

Conversation

vrongmeal
Copy link
Contributor 

> select * from pg.public.comments;
Error: External error: External error: Overflow converting '0001-01-01 00:00:00 UTC' to Timestamp(Nanosecond, Some("UTC"))

Fixes: #2412

@vrongmeal
fix: Error instead of panic when converting pg timestamps to arrow
03db3fc 
```
> select * from pg.public.comments;
Error: External error: External error: Overflow converting '0001-01-01 00:00:00 UTC' to Timestamp(Nanosecond, Some("UTC"))
```

Fixes: #2412

Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal vrongmeal merged commit 5d57665 into main Jan 16, 2024
19 checks passed
@vrongmeal vrongmeal deleted the vrongmeal/timestamp-panic branch January 16, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tychoish tychoish tychoish approved these changes

@scsmithr scsmithr Awaiting requested review from scsmithr

@universalmind303 universalmind303 Awaiting requested review from universalmind303

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic (without helpful error) for pg table with timestamp
2 participants
@vrongmeal @tychoish