chore: pytest hacking #2606
Merged
chore: pytest hacking #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tychoish
commented
Feb 7, 2024
tychoish
commented
- ran black over the code
- added an env setting
- did a little light refactoring on the dbt tests
- moving some files around
talagluck
approved these changes
Feb 8, 2024
Comment on lines
+19
to
+31
| @contextlib.contextmanager | ||
| def env(key: str, val: str): | ||
| prev = os.getenv(key) | ||
|
|
||
| os.environ[key] = val | ||
|
|
||
| try: | ||
| yield | ||
| finally: | ||
| if prev is None: | ||
| del os.environ[key] | ||
| else: | ||
| os.environ[key] = prev |
There was a problem hiding this comment.
Could you explain the need for this?
There was a problem hiding this comment.
environment variables can either be set, or unset, or set to the empty string, (which is sort of ambiguous.) and the context manager just means that you can have a with block where the environment variable is set to one thing. and then is restored to its previous state when you exit the block
talagluck
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.