fix(information_schema): identity_cycle, is_updatable #2616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greyscaled
changed the title
tychoish
approved these changes
Feb 9, 2024
tychoish
pushed a commit
that referenced
this pull request
Feb 15, 2024
Noticed these typos while doing something else...just a hygiene skim, and not the result of some error from a pg integration. Taken from https://www.postgresql.org/docs/current/infoschema-columns.html#INFOSCHEMA-COLUMNS. From that spec, we are additionally missing the column `character_octet_length`, which seems like it should be derived as 0 or `null` based on whether `c.data_type` is character-based, though maybe just passing in `null` or even omitting it for now is fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed these typos while doing something else...just a hygiene skim, and not the result of some error from a pg integration.
Taken from https://www.postgresql.org/docs/current/infoschema-columns.html#INFOSCHEMA-COLUMNS.
From that spec, we are additionally missing the column
character_octet_length, which seems like it should be derived as 0 ornullbased on whetherc.data_typeis character-based, though maybe just passing innullor even omitting it for now is fine?