-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: insert into sqlite tables #2745
Conversation
Yeah, we do create the client in "read-only" mode: glaredb/crates/datasources/src/sqlite/wrapper.rs Lines 32 to 36 in 9c27dd0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this looks good!
Co-authored-by: Sean Smith <scsmithr@gmail.com>
Co-authored-by: Sean Smith <scsmithr@gmail.com>
Thanks to @vrongmeal for all the sqlite infrastructure and spotting my bug.
Should be good to go now.