Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: insert into sqlite tables #2745

Merged
merged 9 commits into from
Mar 6, 2024
Merged

feat: insert into sqlite tables #2745

merged 9 commits into from
Mar 6, 2024

Conversation

tychoish
Copy link
Contributor

@tychoish tychoish commented Mar 6, 2024

Thanks to @vrongmeal for all the sqlite infrastructure and spotting my bug.

Should be good to go now.

@vrongmeal
Copy link
Contributor

This is close, but the test fails with a common error from SQLite on
the insert statement (e.g. attempt to write a readonly database). I'm pretty sure that this isn't due to the python sqlite
library which creates the db and sets things up, but something with
how we (probably?) create the sqlite client object.

Yeah, we do create the client in "read-only" mode:

let inner = async_sqlite::ClientBuilder::new()
.flags(OpenFlags::SQLITE_OPEN_READ_ONLY)
.path(&path)
.open()
.await?;

Copy link
Contributor

@vrongmeal vrongmeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this looks good!

Co-authored-by: Sean Smith <scsmithr@gmail.com>
@tychoish tychoish enabled auto-merge (squash) March 6, 2024 16:29
@tychoish tychoish merged commit db9e5b3 into main Mar 6, 2024
25 checks passed
@tychoish tychoish deleted the tycho/sqlite-inserts branch March 6, 2024 16:38
tychoish added a commit that referenced this pull request Mar 6, 2024
Co-authored-by: Sean Smith <scsmithr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants