refactor: move parser into own crate #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…glaredb into universalmind303/extract-parser
scsmithr
approved these changes
Mar 6, 2024
some more prereq work for making the tableoptions more flexible as part of #2744. The `Arbitrary` trait has a cascading effect, so it's kind of all or nothing, and since we can't have `trait TableOptions: Arbitrary` in an object-safe way, it's gotta go.
tychoish
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
This seems my only question/concern is "should we worry about the proptest or think about replacing it?"
I don't know if there's anything to be done about it, but the name collision between our parser and the upstream parser package (particularly ParserError) seems like a thing that will be confusing in the future.
| @@ -25,6 +25,7 @@ futures = { workspace = true } | |||
| gcp-bigquery-client = "0.18.0" | |||
| klickhouse = { version = "0.11.2", features = ["tls"] } | |||
| protogen = { path = "../protogen" } | |||
| parser = {path = "../parser"} | |||
There was a problem hiding this comment.
super-nit: we added spaces in other places for this form.
idle musing: is there a toml linter we could get?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some prereq work for #2744