Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly alias all sessions #2802

Merged
merged 4 commits into from
Mar 20, 2024
Merged

fix: properly alias all sessions #2802

merged 4 commits into from
Mar 20, 2024

Conversation

universalmind303
Copy link
Contributor

@universalmind303 universalmind303 commented Mar 20, 2024 •
edited
Loading

closes #2779

manually tested in cloud via:

create view "broken_sky"."public"."my_view" as select 1;
select * from "broken_sky"."public"."my_view";

@greyscaled greyscaled mentioned this pull request Mar 20, 2024
Merged
tychoish
tychoish reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@tychoish tychoish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, other than that this seems good.

crates/sqlexec/src/engine.rs Show resolved Hide resolved
@universalmind303 universalmind303 enabled auto-merge (squash) March 20, 2024 16:23
@universalmind303 universalmind303 merged commit acc2deb into main Mar 20, 2024
25 checks passed
@universalmind303 universalmind303 deleted the universalmind303/db-alias-fix branch March 20, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tychoish tychoish tychoish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: infer db name on SELECT and not just on CREATE
2 participants
@universalmind303 @tychoish