Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: df 36 upgrade #2853

Merged
merged 6 commits into from
Apr 8, 2024
Merged

chore: df 36 upgrade #2853

merged 6 commits into from
Apr 8, 2024

Conversation

universalmind303
Copy link
Contributor

@universalmind303 universalmind303 commented Apr 3, 2024

Still a few items todo

  • get functions removed from BuiltinScalarFunctions added back in (Isnan, Encode, ...)
  • doublecheck array_append functionality

Copy link
Contributor

@tychoish tychoish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just questions, otherwise seems good.

testdata/sqllogictests/datatypes.slt Show resolved Hide resolved
testdata/sqllogictests/functions/hashing.slt Show resolved Hide resolved
@universalmind303
Copy link
Contributor Author

I want to wait to hear back about this datafusion regression before merging this.

@universalmind303 universalmind303 merged commit 36a391b into main Apr 8, 2024
26 checks passed
@universalmind303 universalmind303 deleted the universalmind303/datafusion36 branch April 8, 2024 15:49
tychoish pushed a commit that referenced this pull request Apr 9, 2024
Still a few items todo

- [x] get functions removed from `BuiltinScalarFunctions` added back in
(Isnan, Encode, ...)
- [x] doublecheck `array_append` functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants