Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: read_blob #2902

Merged
merged 7 commits into from
Apr 17, 2024
Merged

feat: read_blob #2902

merged 7 commits into from
Apr 17, 2024

Conversation

universalmind303
Copy link
Contributor

@universalmind303 universalmind303 commented Apr 16, 2024 •
edited
Loading

closes #2683

tychoish
tychoish approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@tychoish tychoish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want someone else to also look at this, but this seems pretty straight forward.

vrongmeal
vrongmeal reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@vrongmeal vrongmeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a suggestion about removing the hack.

crates/sqlbuiltins/src/functions/table/read_blob.rs Outdated Show resolved Hide resolved
@universalmind303 universalmind303 enabled auto-merge (squash) April 17, 2024 15:43
@universalmind303 universalmind303 merged commit 2b7035a into main Apr 17, 2024
26 checks passed
@universalmind303 universalmind303 deleted the universalmind303/read-blob branch April 17, 2024 15:57
tychoish pushed a commit that referenced this pull request Apr 17, 2024
@universalmind303 @tychoish
feat: read_blob (#2902)
dc53418 
closes #2683
tychoish pushed a commit that referenced this pull request Apr 19, 2024
@universalmind303 @tychoish
feat: read_blob (#2902)
1e80cfe 
closes #2683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrongmeal vrongmeal vrongmeal left review comments

@scsmithr scsmithr scsmithr approved these changes

@tychoish tychoish tychoish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

read_blob function
4 participants
@universalmind303 @tychoish @scsmithr @vrongmeal