feat: read_text table function #2924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychoish
approved these changes
Apr 23, 2024
Comment on lines
+205
to
+213
| columns.sort_by(|a, b| a.0.cmp(&b.0)); | ||
|
|
||
| let batch = RecordBatch::try_new( | ||
| schema.clone(), | ||
| columns.into_iter().map(|(_, v)| v).collect(), | ||
| )?; | ||
|
|
||
| let stream = once(async move { Ok(batch) }).boxed(); | ||
| Ok(stream) |
There was a problem hiding this comment.
let me see if I understand this:
so this is all running (already) inside of an async function/task, and we start another task to convert something into a stream, which produces a record batch that has exactly one row in it?
(I think also that we can call .flatten() to avoid the extra function here; and also the sort is cheap in this case but probably can be enforced procedurally in the code)
| select filename from read_text('gs://${GCS_BUCKET_NAME}/multi_csv/**/*', gcp_creds); | ||
| ---- | ||
| multi_csv/bikeshare_stations.csv | ||
| multi_csv/bikeshare_stations_2.csv |
There was a problem hiding this comment.
is there a way to assert in an SLT that the value that we expect to have data/content isn't empty?
There was a problem hiding this comment.
yeah we are testing that in testdata/sqllogictests/functions/read_text.slt
query I
select content from read_text('./testdata/blob/hello.txt');
----
hello world
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.