fix: Don't preprocess database name when setting session catalog alias #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were doing some processing on the database to try to extract out the "true" name from names that follow the "org/database" format. However that meant if some connects to the db over postgres using a hostname like "proxy.glaredb.com/my_org/my_db", we would set the catalog alias to only "my_db", disallowing queries like `SELECT * FROM "my_org/my_db"."my_schema"."my_table"` even though that's what's expected given the postgres connection string. This change makes the name returned from `SHOW database_name` consistent with the alias we set on the session catalog, allowing the previous query to work as expected.
|
I can't speak to the code here, but the functionality that you describe is as I expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were doing some processing on the database name to try to extract out the "true" name from names that follow the "org/database" format. However that meant if someone connects to the db over postgres using a hostname like "proxy.glaredb.com/my_org/my_db", we would set the catalog alias to only "my_db", disallowing queries like
SELECT * FROM "my_org/my_db"."my_schema"."my_table"even though that's a valid query given the connect string.This change makes the name returned from
SHOW database_nameconsistent with the alias we set on the session catalog, allowing the previous query to work as expected.