Default settings should be Atom's

[pistou]

I've seen #50 and I understood that Atom Beautify settings have to override Atom settings in order to work properly.

Nevertheless, I think that default settings should be Atom settings.
For instance, I use an indent length of 4 on every language. By default, Atom Beautify uses 2.
Here I have to manually edit every indent setting and put them on 4.
System should be abble to find that I already set it to 4 in Atom general settings.

If no Atom Beautify setting is set, can't you check Atom settings ?

[Glavin001]

What if I add a package setting flag that could be toggled on to let Atom's settings override the default Atom Beautify settings, would that work for you?

[pistou]

Would be perfect !

[Glavin001]

Great!

I am in the middle of final exams right now, so I am probably not going to be working on anything until after (a week from today).

For anyone interesting in submitting a Pull Request:

• Add settings flag, such as enforceAtomEditorSettings, see https://github.com/Glavin001/atom-beautify/blob/master/lib/beautify.coffee#L316-L321
• Atom Beautify already extracts the Atom Editor settings: https://github.com/Glavin001/atom-beautify/blob/master/lib/beautify.coffee#L225-L233
• And stores in editorOptions, which is the lower precedence: https://github.com/Glavin001/atom-beautify/blob/master/lib/beautify.coffee#L278-L285
• Use enforceAtomEditorSettings to change order / remove items of allOptions such that the result is as desired

Thanks for using Atom Beautify!

[Glavin001]

I re-read your original comment:

I think that default settings should be Atom settings.
For instance, I use an indent length of 4 on every language. By default, Atom Beautify uses 2.
Here I have to manually edit every indent setting and put them on 4.
System should be abble to find that I already set it to 4 in Atom general settings.

Instead of providing a flag that could be toggled that would change the precedence of the options, I think what would be ideal is actually setting the Atom Beautify default settings to the current values of the Atom Editor (at first launch). Thoughts?

[Glavin001]

This will be resolved by #172. I am updating from using configDefaults to Atom's latest Config API. I am going to make it such that the defaults check atom.config.get('editor.tabLength') and other settings and use those as the default values, as you requested.

[pistou]

Great job 👍