JS Chained methods never break regardless of "Break Chained Method" setting #836

ProustIdee · 2016-02-27T17:49:56Z

With Atom-Beautify 0.28.24.

Input code:

<html>
  <script>
    d3.csv("/data/test.csv", function (d) {
      svg.append('g')
      .selectAll('path');
    });
  </script>
</html>

Result of Beautifying:

<html>
  <script>
    d3.csv("/data/test.csv", function (d) {
      svg.append('g').selectAll('path');
    });
  </script>
</html>

It doesn't matter what I set "Javascript - Break chained methods" to. I'm using the JS Beautify engine.

I didn't have this problem until the last day or two. I assume Atom-Beautify was updated recently?

The text was updated successfully, but these errors were encountered:

Glavin001 · 2016-02-27T21:11:44Z

Please follow the Issue template provided, it is required not a recommendation. For your convience, here it is again: https://github.com/Glavin001/atom-beautify/blob/master/ISSUE_TEMPLATE.md
The most important part being the Gist containing your debugging information. That information would help me resolve many questions I will be asking without a tedious back and forth.

I await your debugging information. Thank you.

Possibly related issues: #831, #830
I believe this issue could be the same. There was a settings bug (incomplete feature) published in v0.28.23 and some users made changes in v0.28.23 and found that their settings did not work. This is because in v0.28.23 the settings groups do not work and in v0.28.24 I have reverted the groups (should not have been pushed, incomplete feature) so those settings that were set in the groups are ignored.

ProustIdee · 2016-02-27T21:55:14Z

I uninstalled Atom-Beautify and reinstalled, I also deleted the Atom-beautify section from my config.cson file.

Here is the debug.md: https://gist.github.com/ProustIdee/d0eb29920a3addc00409

Glavin001 · 2016-02-27T22:52:21Z

The option you used is:

    "js_break_chained_methods": true

Which is language namespace js.

While the language namespace for your code is html, as the grammar detected is HTML.

So Atom Beautify filtered out the options only for html namespace.

I do not see the break_chained_methods in the list of supported HTML language options: https://github.com/Glavin001/atom-beautify/blob/master/src/languages/html.coffee#L28
Feel free to submit a Pull Request, however using the .jsbeautifyrc file can allow any option.

I'd recommend setting break_chained_methods for html namespace in your .jsbeautifyrc file.

Something like:

{
  "html": { "break_chained_methods": true }
}

ProustIdee · 2016-02-27T23:00:19Z

Thanks for the reply. Is there a reason this worked until recently?

The way that I understand it, I should have separate js files and call them from the html file, rather than writing script in the <script> </script> tags in the html file.

However, I didn't have any problems with this until recently, everything worked perfectly.

Glavin001 · 2016-02-27T23:06:59Z

So you had a single HTML file with JavaScript content and using the js_break_chained_methods option everything worked before as expected and now it does not? Strange.
The only thing I could suggest is that maybe Pretty Diff (your currently selected beautifier) has been updated. /cc @prettydiff

Glavin001 · 2016-02-27T23:38:13Z

Updates published to npm for dependencies, such as Pretty Diff or JS-Beautify, are not automatically applied to Atom Beautify in Atom, nor is Atom Beautify even shown as needing an update. However the dependency versions required for dependencies are very loose within Atom Beautify, such that by reinstalling Atom Beautify you can effectively update to the latest version of all the dependencies. For example, Pretty Diff: "prettydiff": "^1.16.17", at https://github.com/Glavin001/atom-beautify/blob/master/package.json#L97

So when you updated Atom Beautify, which has not happened in a while, you likely did update Pretty Diff and those changes made 13 days ago.

@prettydiff this may be an issue on your end then. Let me know if there's anything I can help with.

prettydiff · 2016-02-28T12:37:38Z

Looking at this now. When I run the sample code against the methodchain option used internally by Pretty Diff at http://prettydiff.com/ the output is as expected for the three supported values: chain, indent, none. It appears to correct on the Pretty Diff side.

I am examining this operation in Atom now.

prettydiff · 2016-02-28T12:50:05Z

I think I found the problem in Atom. You can reproduce the problem if Pretty Diff is the beautifier for both HTML and JavaScript. I think this problem is this following line where Pretty Diff is being passed a boolean for its methodchain option:

atom-beautify/src/beautifiers/prettydiff.coffee

Line 34 in 3a6763a

false else true

I am verifying now and also looking to see when/why this was changed on the Pretty Diff side.

prettydiff · 2016-02-28T13:01:46Z

Disregard the previous comment. I appear to be handling boolean values for that option correctly for backwards compatibility. That is not the problem.

The problem is that the language grammar is HTML. When I isolate the JavaScript code and change the language grammar to JavaScript everything work as expected. For some reason the option is not being passed through from HTML to JavaScript in Atom Beautify. I am looking to where this gets dropped.

prettydiff · 2016-02-28T13:13:25Z

I am not sure how to resolve this. I think the error is the settings screen for Atom Beautify (though I have not confirmed this and dont know how). You can set a value for a JavaScript option on that page, and once that option is set the value is cached for that given language grammar. HTML, a different language grammar with a different set of options, sets and applies its options independently. When the current language grammar is HTML you can change JavaScript options to no effect. When you change the language grammar to JavaScript the change in effect is manifest.

I have confirmed that the option setting works correctly if the language grammar is JavaScript. I have also confirmed that whatever setting was chosen for the given option is "locked in" once you change your grammar back to HTML. So long as the grammar is HTML the only thing that is broken is the JavaScript language option on the settings screen.

timothyerwin · 2017-01-03T06:45:08Z

I had the same problem...I had to change the file type in Atom to "JavaScript" as it was set to "Babel ES6 Javascript"

prettydiff · 2017-01-05T00:04:04Z

The solution proposed by @timothyerwin makes me happy. The crux of the problem is that this JavaScript option needs to be exposed for HTML grammars.

prettydiff · 2017-10-10T16:49:31Z

This issue is likely resolved as the latest version of Pretty Diff recently landed in Atom Beautify. If I am in error please reopen this issue.

stevenzeck · 2017-10-10T16:57:53Z

@prettydiff the updates have been published to apm yet, so you won't see changes yet. Should be soon though

prettydiff · 2017-10-10T17:42:35Z

@szeck87 I am aware. Closing all these issues might be a bit premature for the users, but I still feel good about cleaning house and clearing out some of the backlog. Excellent work on that pull request by the way!

JeffML · 2018-03-02T17:25:33Z

Disabling 'Break chained methods' in Javascript settings didn't work for me. I had to disable it in JSX settings.

ProustIdee changed the title ~~Chained methods always break regardless of "Break Chained Method" setting~~ JS Chained methods always break regardless of "Break Chained Method" setting Feb 27, 2016

ProustIdee changed the title ~~JS Chained methods always break regardless of "Break Chained Method" setting~~ JS Chained methods never break regardless of "Break Chained Method" setting Feb 27, 2016

Glavin001 added the waiting-for-user-information label Feb 27, 2016

Glavin001 added question and removed waiting-for-user-information labels Feb 27, 2016

Glavin001 added this to the v0.29.0 milestone Feb 27, 2016

Glavin001 self-assigned this Feb 27, 2016

Glavin001 assigned prettydiff and unassigned Glavin001 Feb 27, 2016

prettydiff assigned Glavin001 and unassigned prettydiff Mar 9, 2016

Glavin001 removed this from the v0.29.0 milestone Mar 30, 2016

prettydiff added enhancement and removed question labels Jan 5, 2017

Glavin001 removed their assignment Apr 20, 2017

prettydiff closed this as completed Oct 10, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JS Chained methods never break regardless of "Break Chained Method" setting #836

JS Chained methods never break regardless of "Break Chained Method" setting #836

ProustIdee commented Feb 27, 2016

Glavin001 commented Feb 27, 2016

ProustIdee commented Feb 27, 2016

Glavin001 commented Feb 27, 2016

ProustIdee commented Feb 27, 2016

Glavin001 commented Feb 27, 2016

Glavin001 commented Feb 27, 2016

prettydiff commented Feb 28, 2016

prettydiff commented Feb 28, 2016

prettydiff commented Feb 28, 2016

prettydiff commented Feb 28, 2016

timothyerwin commented Jan 3, 2017

prettydiff commented Jan 5, 2017

prettydiff commented Oct 10, 2017

stevenzeck commented Oct 10, 2017

prettydiff commented Oct 10, 2017

JeffML commented Mar 2, 2018

JS Chained methods never break regardless of "Break Chained Method" setting #836

JS Chained methods never break regardless of "Break Chained Method" setting #836

Comments

ProustIdee commented Feb 27, 2016

Glavin001 commented Feb 27, 2016

ProustIdee commented Feb 27, 2016

Glavin001 commented Feb 27, 2016

ProustIdee commented Feb 27, 2016

Glavin001 commented Feb 27, 2016

Glavin001 commented Feb 27, 2016

prettydiff commented Feb 28, 2016

prettydiff commented Feb 28, 2016

prettydiff commented Feb 28, 2016

prettydiff commented Feb 28, 2016

timothyerwin commented Jan 3, 2017

prettydiff commented Jan 5, 2017

prettydiff commented Oct 10, 2017

stevenzeck commented Oct 10, 2017

prettydiff commented Oct 10, 2017

JeffML commented Mar 2, 2018