Javascript collapse-preserve-inline does not work

[ttsirkia]

Description

The new option collapse-preserve-inlinefor Javascript does not work.

Expected Results

The beautified code should have looked like:

var a = {b: 4, c: 5};

Steps to Reproduce

1. Add code to Atom editor
2. Run command Atom Beautify: Beautify Editor
3. This beautified code does not look right!

Debug

Here is a link to the debug.md Gist: https://gist.github.com/ttsirkia/ea5ec670aae96d6dedb1

[ttsirkia]

And the result is the same with the version 0.28.24.

[ttsirkia]

If I run js-beautify from command line, the result is the expected so it is not a bug in js-beautify (or at least it looks like that).

> node js-beautify.js -b collapse-preserve-inline test.js
var a = { b: 4, c: 5 };

[Glavin001]

There was a bug in 0.28.23 ( I pushed a feature I had not finished implementing by accident). Could you please update your debug.md with the latest version of Atom Beautify. Thank you!

Also it appears that the changes made by #779 are still available: https://github.com/Glavin001/atom-beautify/blob/master/src/languages/javascript.coffee#L75-L76

I believe the problem will be because of the bug (incomplete feature) I published. I apologize for this.

I see in your debug.md:

 "js": {
        "brace_style": "collapse-preserve-inline",

I recommend that you go into your Atom Beautify package settings again and find JavaScript - Brace Style, or set that instead in your .jsbeautifyrc.
The feature was regarding the re-organization of the settings and it is not complete. It appears that you have set one of the nested options, which was not working in 0.28.23 (not finished yet) and has been removed in 0.28.24, so you are still experiencing the issue.

This should resolve your problems. Let me know if it does not or if you have any more questions.

[ttsirkia]

I already tried this with one computer this morning with the newest version and also changed the settings in the settings view. It didn't work.

Now I upgraded another computer to version 0.28.24 and with this computer it works. I try again with the first computer to see if there was some problems with the upgrade or something else. If there are not any new messages, then everything is fine. Thanks for your response!

[ttsirkia]

Just to confirm, it works now also with the first computer. I deleted the plug-in second time but now the settings from config file as well and installed it again.

[Glavin001]

Sorry about that. I was working on a separate branch and I must have accidently merged it in because 1 stray commit screwed up all of the settings.

Glad to hear it is working now. I think you and other users will be pleased with the new settings organization once I have completed it 😃.

[ttsirkia]

No problem. This is one of the best settings in Atom Beautify / JS-Beautify ever.

[thorstensson]

Hello
Is there a way to not have JSX < > treated as brackets but as if they sat in HTML. First below is very readable:

  render(
    <Router>
         <Route path="/" component={Home}/>
    </Router>,
    document.getElementById(container)
  );

But after formatting (js beautify and prettydiff), I get this:

  render( <
    Router >
    <
    Route path = "/"
    component = {
      Home
    }
    /> <
    /Router>,
    document.getElementById(container)
  );

The last bit causes me to grab an extra cup of coffe . Thanks