Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#776] Bump jsbeautify to 1.6.2. Add support for collapse-preserve-inline #779

Merged
merged 1 commit into from
Feb 20, 2016

Conversation

kaaloo
Copy link
Contributor

@kaaloo kaaloo commented Feb 3, 2016

I have tested the package locally and the option seems to work fine now.

@prettydiff
Copy link
Collaborator

Yeah, the unit tests appear to need some work.

@kaaloo
Copy link
Contributor Author

kaaloo commented Feb 4, 2016

Yup, probably because of the jsbeautify version bump.

@ttsirkia
Copy link
Contributor

+1 for this. It would be great to finally get this particular feature.

@nerdpad
Copy link

nerdpad commented Feb 16, 2016

+1 if we can get this feature.

@Glavin001 Glavin001 added this to the v0.29.0 milestone Feb 20, 2016
@Glavin001 Glavin001 self-assigned this Feb 20, 2016
Glavin001 added a commit that referenced this pull request Feb 20, 2016
[#776] Bump jsbeautify to 1.6.2.  Add support for collapse-preserve-inline
@Glavin001 Glavin001 merged commit 42a747c into Glavin001:master Feb 20, 2016
@kaaloo
Copy link
Contributor Author

kaaloo commented Feb 21, 2016

Thank you that's awesome!

@Glavin001
Copy link
Owner

Published to v0.28.23

@ttsirkia
Copy link
Contributor

After a short experiment, it seems that objects are still expanded to multiple lines as before although this new option is selected. Can someone else share experiences?

var a = {b: 4, c: 5};

becomes

var a = {
  b: 4,
  c: 5
};

@Glavin001
Copy link
Owner

@ttsirkia please create a new issue and follow the instructions provided in the template. Thank you.

@ttsirkia
Copy link
Contributor

Sure, #831. I was just asking if someone could give a quick comment if there is only something wrong in my environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants