Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSX option to to JS Beautify #1428

Merged
merged 1 commit into from
Dec 29, 2016

Conversation

NodeJoSe
Copy link
Contributor

What does this implement/fix? Explain your changes.

I would love to use the language-babel syntax package and JS Beautify together for my js files, this will make it possible!

@Glavin001
Copy link
Owner

.js files are not .jsx (JSX) files. Can you provide more information about this?
However, it looks like JS Beautify does support JSX syntax: beautifier/js-beautify#425 (comment)
My main concern is allowing users to use JS Beautify and have it break their JSX code.

@Glavin001 Glavin001 self-assigned this Dec 29, 2016
@NodeJoSe
Copy link
Contributor Author

Lenguaje-Babel is a package to add syntax highlight to JS files for JavaScript ES201x, plus React JSX files, i was using it to get better syntax on my js files using some es6 features, but i wont be able to use JS Beautify because it add a new gramar to my JS files "Babel ES6 JavaScript"

Maybe its better just to add that gramar to the JS Beautify options, and not the whole JSX, it is possible?

@Glavin001 Glavin001 merged commit 594c170 into Glavin001:better-settings Dec 29, 2016
@Glavin001
Copy link
Owner

Thanks for contributing!

@NodeJoSe
Copy link
Contributor Author

ill remake this pull request on the master branch too, sorry about that

@Glavin001
Copy link
Owner

Published to v0.29.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants