Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usage and support #17

Merged
merged 8 commits into from
Jun 13, 2014
Merged

Improve usage and support #17

merged 8 commits into from
Jun 13, 2014

Conversation

Glavin001
Copy link
Owner

@Glavin001
Copy link
Owner Author

@donaldpipowitch I think I may leave the Specs and Travis CI for later.

Applied in order of precedence:
- Default
- User Home .jsbeautifyrc
- Closest .jsbeautify to the current file, see #15
@Glavin001
Copy link
Owner Author

@donaldpipowitch I am done now.

For those who wish to use this before it is published to Atom's packages:

In your Terminal, change into a safe directory for cloning the repo and then run:

# Clone fork repo
git clone git@github.com:Glavin001/atom-beautify.git
# Change into repo directory
cd atom-beautify/
# Install dependencies
npm install
# Uninstall old atom-beautify, if applicable
apm uninstall atom-beautify
# Link and use this atom-beautify
apm link

/cc @Frozenfire92

@donaldpipowitch
Copy link
Contributor

Wow, this looks awesome! I'll be in my honeymoon in the next two weeks, so I can't look into the pull request in detail before merging.

@karolyi Could you make a short review for this pull request and merge it into the master afterwards? Just if you have some spare time. Else I would do it after 2 weeks.

Thank you both very much!

@Glavin001
Copy link
Owner Author

Thanks, @donaldpipowitch!

No worries. In the meantime, everyone can use the script I commented above. 😉 😉 for @Frozenfire92

@karolyi, let me know if there's anything else I can do.

@donaldpipowitch, congratulations and have an amazing honeymoon!!

@Frozenfire92
Copy link

# Clone fork repo
git clone git@github.com:Glavin001/atom-beautify.git
# Change into repo directory
cd atom-beautify/
# Install dependencies
npm install
# Uninstall old atom-beautify, if applicable
apm uninstall atom-beautify
# Link and use this atom-beautify
apm link
# Update dependencies
npm install
# Restart atom

@Glavin001
Copy link
Owner Author

Thanks for updating thank, @Frozenfire92 . I noticed I forgot the npm install part and, of course, restarting Atom. 👍

@Glavin001
Copy link
Owner Author

@karolyi I updated my PR, fixing those lines you commented on. Thanks.

@karolyi
Copy link
Collaborator

karolyi commented Jun 13, 2014

Thx, currently reviewing ... :) Stay tuned.

karolyi added a commit that referenced this pull request Jun 13, 2014
Improve usage and support
@karolyi karolyi merged commit fe0dc7b into Glavin001:master Jun 13, 2014
@karolyi
Copy link
Collaborator

karolyi commented Jun 13, 2014

All cool, merging 👍

@Glavin001
Copy link
Owner Author

Thank you, @karolyi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single .jsbeautifyrc for a project (in project's root directory)
4 participants