Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed in this issue that importing this library does not work with Webpack correctly #41
Solution
The solution is to remove
browser
field because it was pointing to version of global ExtPay which is meant to be used when you want to have global variableExtPay
. But sincepackage.json
is meant for npm modules this is not what we want to do.Very big libraries which are meant for browser do no use
browser
field ofpackage.json
. Great example from Vue.js (https://github.com/vuejs/vue/blob/main/package.json#L6). They only specifymain
+ other fields but nobody usesbrowser
.How to test?
Use ExtPay library in Webpack and Rollup or some other bundler and see if you can now just import ExtPay like this
and run the code to see if you get any errors. If you don't then everything is cool!
Fixes #41