Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the placeholders and spaces to the translation textarea #1868

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

amieiro
Copy link
Member

@amieiro amieiro commented Oct 16, 2024

Problem

In #1620 we introduced a wrapper to highlight the placeholders, and in #1500 we introduced a similar wrapper to highlight leading and trailing spaces, and double/multiple spaces in the middle.

When a translator clicks on some of these elements, they are not copied to the translation textarea when you click on the placeholder or in the space.

Solution

This PR adds this improvement, so when you click on one of these gray squares (see the screenshot below), this item (placeholders or space) is copied to the translation textarea, where the cursor is placed.

image

@amieiro amieiro marked this pull request as ready for review October 16, 2024 19:42
@amieiro amieiro assigned akirk, trymebytes and amieiro and unassigned akirk and trymebytes Oct 16, 2024
@fxbenard
Copy link

As all those spaces are usually wrong or bad and have no place in the translation, I don't see the point of such a feature.

@amieiro
Copy link
Member Author

amieiro commented Oct 17, 2024

@fxbenard I totally agree. These spaces are usually a programming error, but the translations need them, because the developer needs these spaces in the translation, so I think it is an improvement to give this functionality to the translators.

@fxbenard
Copy link

@amieiro As said as those are mostly errors in the source code, i don't get why they're important in the translations. BTW most translators remove them.
A better way to notify devs about those will be a better improvement that allowing those errors to be pushed across TMs
My 2 cts…. But thanks for this anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants