Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#499 - Adds banlist command #518

Merged
merged 6 commits into from
Jul 5, 2017
Merged

#499 - Adds banlist command #518

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd7e388
Ignore .DS_Store files generated by macOS
FlorentClarret Jul 4, 2017
946cda8
Implement the banlist command
FlorentClarret Jul 4, 2017
779d13e
Improve the banlist commandline
FlorentClarret Jul 5, 2017
0dee0fd
Fix the tabComplete for the banlist command
FlorentClarret Jul 5, 2017
7f87b60
Remove unused imports
FlorentClarret Jul 5, 2017
7f9e386
Fix tabComplete in banlist when args length is equal to 1
FlorentClarret Jul 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/main/java/net/glowstone/command/minecraft/BanListCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@ public boolean execute(CommandSender sender, String commandLabel, String[] args)

@Override
public List<String> tabComplete(CommandSender sender, String alias, String[] args) throws IllegalArgumentException {
if (args.length == 1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No... you still need that check :)

if (args.length == 1) {
    return StringUtil.copyPartialMatches(args[0], BAN_TYPES, new ArrayList(BAN_TYPES.size()));
}
return args.length == 0 ? super.tabComplete(sender, alias, args) : Collections.emptyList();

return StringUtil.copyPartialMatches(args[0], BAN_TYPES, new ArrayList(BAN_TYPES.size()));
} else {
return Collections.emptyList();
}
return args.length == 0 ? super.tabComplete(sender, alias, args) : Collections.emptyList();
}
}