#499 - Implement toggledownfall, spawnpoint, setidletimeout and setworldspawn #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramperes
requested changes
Jul 8, 2017
| } | ||
|
|
||
| if (timeout <= 0) { | ||
| sender.sendMessage(ChatColor.RED + "Timeout has to be positive"); |
There was a problem hiding this comment.
Replace this with The number you have entered (<Number>) is too small, it must be at least 0
| } | ||
|
|
||
| Bukkit.getServer().setIdleTimeout(timeout); | ||
| Bukkit.broadcastMessage("The idle timeout has been set to '" + timeout + "' minutes."); |
There was a problem hiding this comment.
Send this to the sender (not broadcast). The message should say Successfully set the idle timeout to <Number> minutes.
| if (sender instanceof Player) { | ||
| targets = ImmutableList.of((Player) sender); | ||
| } else { | ||
| sender.sendMessage(ChatColor.RED + "Current sender is not a player."); |
There was a problem hiding this comment.
Replace this with You must specify which player you wish to perform this action on.
| if (world == null) { | ||
| return false; | ||
| } else { | ||
| if (world.hasStorm()) { |
There was a problem hiding this comment.
Replace this if-block with:
world.setThundering(!world.hasStorm());
world.setStorm(!world.hasStorm());
FlorentClarret
changed the title
aramperes
approved these changes
Jul 9, 2017
|
Thank you again for your contribution! |
Postremus
pushed a commit
to MyPlayPlanet/Glowstone
that referenced
this pull request
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Another PR on the #499 issue. This time, I added toggledownfall, spawnpoint and setidletimeout.
I saw that no commands had unit tests so far. I implemented some on those three commands mainly using mockito. Tell me what you think of it, if it's really relevant or not.
Edit: I also added the /setworldspawn command.