Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse switches from CLI #186

Closed
wants to merge 5 commits into from
Closed

Parse switches from CLI #186

wants to merge 5 commits into from

Conversation

nappex
Copy link
Collaborator

@nappex nappex commented Jun 9, 2023

Parse switches for work directory. If we want to parse work dir we have parse newly component also.

nappex added 2 commits June 9, 2023 11:23
   - parse output path and component to run as
   switch -o and --component
@nappex
Copy link
Collaborator Author

nappex commented Jun 9, 2023

I am not sure about naming the switches, output for working directory is not something obvious at first sight. Working means where inputs are saved or output should going to or both at one place.

@nappex
Copy link
Collaborator Author

nappex commented Jun 9, 2023

Other task what should be done is to make tests.
I have to more explore the ways how to test private functions. I am not really comfort with this explanation unfortunately.

@nappex
Copy link
Collaborator Author

nappex commented Jul 29, 2023

We should consider library Optimus for parsing cli arguments as far as the onigumo is CLI app.
It would be fine to keep current solution and when cli become more complicated we can switch to Optimus.

lib/cli.ex Outdated Show resolved Hide resolved
Copy link
Owner

@Glutexo Glutexo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should split the pull request into two separate ones:

Also, output may not be the best name for the argument. It is more a “working directory” rather than an output. The actual “output” is what the Materializer spits out.

@nappex nappex marked this pull request as draft October 15, 2023 16:32
   --working-dir is switch which allow user use different
   working directory than only current working directory
Copy link
Owner

@Glutexo Glutexo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@nappex
Copy link
Collaborator Author

nappex commented Feb 24, 2024

  • Test working dir exist and contains corresponding files
  • Test unreachable path, there is a file with same name with working-dir

@Glutexo
Copy link
Owner

Glutexo commented May 10, 2024

  • Test working dir exist and contains corresponding files
  • Test unreachable path, there is a file with same name with working-dir

For those, issues #218 and #219 were created.

@Glutexo Glutexo closed this May 10, 2024
@Glutexo Glutexo deleted the cli-work-dir branch May 10, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants